Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time out the code discovery phase of cnd create #150

Closed
rberrelleza opened this issue Jan 25, 2019 · 0 comments
Closed

Time out the code discovery phase of cnd create #150

rberrelleza opened this issue Jan 25, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@rberrelleza
Copy link
Member

Describe the bug
On very large repos, the code analysis we perform as part of cnd create (to detect the main language) can take a very long time. Yesterday, on a friend's repo (an ML-based app full of data and models) it would take minutes. And there wasn't any output while this was happening.

Expected behavior
I think that the create job should always be almost instantaneous. We should maybe limit the number of files we parse, or have a 1s timeout, and then do our best guess based on the information collected.

Desktop (please complete the following information):

  • OS: macOS
  • Version 0.4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant