environment variables cannot be escaped in the compose file

[AdrianPedriza]

Describe the bug
when I try to escape the value of an environment variable as allowed by docker, the escaped value is not reflected in my deployment.

To Reproduce
Steps to reproduce the behavior:

(Using docker compose)

1. create a compose file

services:
  servicea:
      image: nginx
      environment:
        TESTA: $${myenv}
        TESTB: avalue

2. Run docker-compose up
3. See envs in container (docker exec <container-id> /usr/bin/env) contains escaped value:

(using okteto)

1. Using same compose file, exec okteto deploy -f docker-compose.yml
2. See envs in pod doesn't contain escaped env

Expected behavior
I expect a behavior similar to that of docker compose where the escaped variable is correctly added as env

[AgustinRamiroDiaz]

Additional context from my debugging: Seems like we are expanding the envvars twice, because the stack expander is already expanding the envvars and changes the $${envvar} to ${envvar}

okteto/pkg/model/stack_expander.go

Line 12 in ee65cf2

expandValue, err := ExpandEnv(node.Value, true)

But at some point in the future we are again expanding the envvars ofw the manifest again

okteto/pkg/model/serializer.go

Line 1285 in ee65cf2

value, err = ExpandEnv(value, true)

and that's where we lose ${envvar} for "" . My intuition tells me we should only do it only in the manifest, but we should see the different behaviors

@teresaromero I remember you've worked with the yaml expander, do you have any idea around this?

[teresaromero]

@AgustinRamiroDiaz if i recall correctly, the stack expander using the nodes was introduced in order to parse correctly the multiline envs... from that persperctive, if escaped envs are not being correctly expanded,

@AdrianPedriza could we add a unit test to ExpandEnv with this inputs and expected output to trace if the format is correct? sorry i dont remember 100% how this was expanded

[github-actions]

This issue is stale because it has been open for 60 days with no activity. Comment on this issue or it will be closed in 7 days