Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: popper component #190

Merged
merged 16 commits into from
Jul 14, 2023
Merged

feat: popper component #190

merged 16 commits into from
Jul 14, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Jul 6, 2023

close: #167

@productdevbook productdevbook self-assigned this Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.75% 595 / 702
🔵 Statements 84.75% 595 / 702
🔵 Functions 80.76% 21 / 26
🔵 Branches 77.08% 37 / 48
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/popper/src/popper.ts 97.14% 66.66% 66.66% 97.14% 47-48
Generated in workflow #354

@productdevbook
Copy link
Member Author

Brach popper

Radix Popover Styled Storybook

Radix Code

Oku Popover Styled: http://localhost:6006/?path=/story/components-popper--styled

When you scroll and press the button there, the popper starts animation from the left corner, and there are some other visible bugs.

  1. arrow is not on the box.
    image

  2. Transition animation problem

<Transition>
<OkuPopperContent v-if="pressed" :side-offset="5" side="top" align="start">
<button class="bg-blue-500" @click="setPressed(!pressed)">
close
</button>
<OkuPopperArrow class="fill-red-500" width="20" height="20" offset="0" />
</OkuPopperContent>
</Transition>

image

@productdevbook productdevbook marked this pull request as ready for review July 13, 2023 13:49
@dammy001 dammy001 merged commit c402fd9 into main Jul 14, 2023
5 checks passed
@dammy001
Copy link
Contributor

LGTM

@github-actions github-actions bot mentioned this pull request Jul 14, 2023
@productdevbook productdevbook deleted the popper branch July 15, 2023 18:22
@github-actions github-actions bot mentioned this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component popper package
2 participants