Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(switch): new switch component #237

Merged
merged 17 commits into from
Jul 22, 2023
Merged

feat(switch): new switch component #237

merged 17 commits into from
Jul 22, 2023

Conversation

dammy001
Copy link
Contributor

Description

Linked Issues

Additional context

@dammy001 dammy001 marked this pull request as draft July 21, 2023 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023 •
edited

Thank you for following the naming conventions! 🙏

@dammy001 dammy001 requested a review from YeSuX July 21, 2023 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023 •
edited

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.55% 1226 / 1485
🔵 Statements 82.55% 1226 / 1485
🔵 Functions 79.54% 35 / 44
🔵 Branches 76.36% 84 / 110
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/popper/src/popper.ts 97.01% 66.66% 66.66% 97.01% 48-49
packages/components/switch/src/BubbleInput.ts 96.22% 57.14% 100% 96.22% 63-66
packages/components/switch/src/Switch.ts 99.5% 81.25% 100% 99.5% 121
packages/components/switch/src/SwitchThumb.ts 59.74% 100% 0% 59.74% 37-67
packages/components/switch/src/index.ts 100% 100% 100% 100%
packages/components/switch/src/util.ts 100% 100% 100% 100%
packages/core/primitive/src/index.ts 100% 100% 100% 100%
packages/core/primitive/src/primitive.ts 95.54% 79.16% 100% 95.54% 125, 149-151, 162, 179-182
Generated in workflow #442

@dammy001 dammy001 marked this pull request as ready for review July 21, 2023 22:40
@productdevbook productdevbook changed the title feat: switch component feat(switch): new switch component Jul 22, 2023
@productdevbook productdevbook merged commit 6633d29 into main Jul 22, 2023
7 checks passed
@productdevbook productdevbook deleted the feat/switch branch July 22, 2023 09:44
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@productdevbook productdevbook productdevbook approved these changes

@YeSuX YeSuX Awaiting requested review from YeSuX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dammy001 @productdevbook