Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): useComposeRefs and useForwardRef #252

Merged
merged 7 commits into from
Jul 31, 2023
Merged

feat(core): useComposeRefs and useForwardRef #252

merged 7 commits into from
Jul 31, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Jul 30, 2023

Description

Linked Issues

close #249

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook self-assigned this Jul 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.18% 1347 / 1600
🔵 Statements 84.18% 1347 / 1600
🔵 Functions 82% 41 / 50
🔵 Branches 77.6% 97 / 125
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/arrow/src/arrow.ts 86.15% 60% 100% 86.15% 30-38
packages/components/aspect-ratio/src/aspect-ratio.ts 100% 75% 100% 100%
packages/components/label/src/label.ts 88.63% 100% 75% 88.63% 24-28
packages/components/popper/src/popper.ts 96.87% 66.66% 66.66% 96.87% 47-48
packages/components/separator/src/separator.ts 100% 77.77% 100% 100%
packages/components/switch/src/BubbleInput.ts 96.03% 57.14% 100% 96.03% 64-67
packages/components/switch/src/Switch.ts 99.5% 81.25% 100% 99.5% 126
packages/components/switch/src/SwitchThumb.ts 65.75% 100% 0% 65.75% 38-62
packages/components/switch/src/index.ts 100% 100% 100% 100%
packages/components/toggle/src/toggle.ts 100% 83.33% 100% 100%
packages/components/visually-hidden/src/VisuallyHidden.ts 100% 100% 100% 100%
packages/core/primitive/src/index.ts 100% 100% 100% 100%
packages/core/primitive/src/primitive.ts 95.75% 79.16% 100% 95.75% 133, 157-159, 170, 187-190
packages/core/use-composable/src/useComposeRefs.ts 100% 75% 100% 100%
Generated in workflow #471

Copy link
Contributor

@dammy001 dammy001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@productdevbook productdevbook merged commit d9a32a8 into main Jul 31, 2023
7 checks passed
@productdevbook productdevbook deleted the new-core branch July 31, 2023 03:15
@github-actions github-actions bot mentioned this pull request Jul 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core packages composeRefs
2 participants