Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dismissable-layer): new dismissable layer component #269

Merged
merged 34 commits into from
Aug 23, 2023
Merged

feat(dismissable-layer): new dismissable layer component #269

merged 34 commits into from
Aug 23, 2023

Conversation

dammy001
Copy link
Contributor

@dammy001 dammy001 commented Aug 4, 2023

Description

Linked Issues

Additional context

@dammy001 dammy001 marked this pull request as draft August 4, 2023 08:03
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023 •
edited

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023 •
edited

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.6% 4535 / 5424
🔵 Statements 83.6% 4535 / 5424
🔵 Functions 69.33% 156 / 225
🔵 Branches 81.68% 339 / 415
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/dismissable-layer/src/DismissableLayer.ts 44.86% 100% 0% 44.86% 127, 147-333
packages/components/dismissable-layer/src/util.ts 74.37% 87.5% 40% 74.37% 42-50, 54-85, 105-108, 112, 151, 161-164
packages/components/focus-scope/src/focus-scope.ts 94.68% 64.1% 81.81% 94.68% 118, 149-156, 206, 218, 230-231, 261-263
packages/components/switch/src/Switch.ts 98.13% 85% 88.88% 98.13% 120-122, 134
packages/core/primitive/src/index.ts 100% 100% 100% 100%
packages/core/primitive/src/utils.ts 76.27% 100% 33.33% 76.27% 10-16, 38-44
Generated in workflow #673

@productdevbook productdevbook linked an issue Aug 8, 2023 that may be closed by this pull request
@radix-ui/react-dismissable-layer package needs to be written #234
Closed
1 task
@Cr0zy07 Cr0zy07 mentioned this pull request Aug 13, 2023
Merged
1 task
@dammy001 dammy001 marked this pull request as ready for review August 21, 2023 07:56
@dammy001 dammy001 changed the title feat: dismissable layer component feat(dismissable-layer, focus-guards): new dismissable layer and focus-guards component Aug 21, 2023
@productdevbook productdevbook changed the title feat(dismissable-layer, focus-guards): new dismissable layer and focus-guards component feat(dismissable-layer): new dismissable layer component Aug 21, 2023
@productdevbook productdevbook marked this pull request as draft August 21, 2023 17:45
@dammy001 dammy001 marked this pull request as ready for review August 23, 2023 15:27
@productdevbook productdevbook merged commit 376ecb9 into main Aug 23, 2023
6 checks passed
@productdevbook productdevbook deleted the feat/dismissable-layer branch August 23, 2023 16:51
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@productdevbook productdevbook productdevbook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@radix-ui/react-dismissable-layer package needs to be written
2 participants
@dammy001 @productdevbook