Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roving focus dir issue #315

Merged
merged 8 commits into from
Aug 31, 2023
Merged

fix: roving focus dir issue #315

merged 8 commits into from
Aug 31, 2023

Conversation

YeSuX
Copy link
Collaborator

@YeSuX YeSuX commented Aug 28, 2023

Description

Linked Issues

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook changed the title Fix/roving focus dir issue fix: roving focus dir issue Aug 29, 2023
@dammy001
Copy link
Contributor

@YeSuX fix failing CI

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.13% 4657 / 5535
🔵 Statements 84.13% 4657 / 5535
🔵 Functions 68.58% 155 / 226
🔵 Branches 81.35% 336 / 413
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 79.55% 60% 13.33% 79.55% 84-85, 110-111, 113-114, 116-117, 119-120, 135, 137, 140, 142-163, 166, 168
Generated in workflow #716

@dammy001 dammy001 merged commit 480b68e into main Aug 31, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
@productdevbook productdevbook deleted the fix/roving-focus branch August 31, 2023 06:51
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants