Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toggle-group): migrate single and multiple groups to a single component #318

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

productdevbook
Copy link
Member

Description

single and multiple in-kind components. That's why it's a one-component translation. This toolbar will make it easier to write and any errors there will be gone.

Linked Issues

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook changed the title refactor: toggle group single and multiple to one component refactor(toggle-group): toggle group single and multiple to one component Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.18% 4727 / 5549
🔵 Statements 85.18% 4727 / 5549
🔵 Functions 69.46% 157 / 226
🔵 Branches 81.99% 346 / 422
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/roving-focus/src/RovingFocusGroup.ts 100% 100% 100% 100%
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 80.33% 81.81% 14.28% 80.33% 83-84, 109-110, 112-113, 118-119, 134, 136, 139, 141-162, 165, 167
packages/components/toggle/src/toggle.ts 98.52% 85.71% 88.88% 98.52% 87, 90
Generated in workflow #713

@productdevbook productdevbook changed the title refactor(toggle-group): toggle group single and multiple to one component refactor(toggle-group): migrate single and multiple groups to a single component Aug 30, 2023
@productdevbook productdevbook merged commit 5286457 into main Aug 31, 2023
7 checks passed
@productdevbook productdevbook deleted the fix-toggle-group branch August 31, 2023 09:31
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant