Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scroll-area): new component #341

Merged
merged 79 commits into from
Sep 20, 2023

Conversation

Cr0zy07
Copy link
Collaborator

@Cr0zy07 Cr0zy07 commented Sep 7, 2023

Description

Linked Issues

close #18

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Thank you for following the naming conventions! 🙏

@productdevbook
Copy link
Member

You best ❤️ ❤️

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Sep 9, 2023

Hi @productdevbook, could you please take a look at the last file I pushed? I'm having trouble moving forward with it. Thank you!

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Sep 19, 2023

Hey @productdevbook, could you please check this issues:

  • hasThumb is always false .
  • The data-state attribute inside scroll-area-thumb-impl is always set to hidden, which is related to the above issue.
  • The thumb positions is't changing
  • The dir in Basic story doesn't seem to be reactive, I tried using v-model, but the issue remains.

Thank you!

But actually, the thumb positions still not changing, i mean thumbRef.value.style.transform = translate3d(...) inside scroll-area-scrollbar-visible not applied :(

@productdevbook
Copy link
Member

But actually, the thumb positions still not changing, i mean thumbRef.value.style.transform = translate3d(...) inside scroll-area-scrollbar-visible not applied :(

Can you make a video on how to bug it and see it, because I don't fully understand it

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Sep 19, 2023

But actually, the thumb positions still not changing, i mean thumbRef.value.style.transform = translate3d(...) inside scroll-area-scrollbar-visible not applied :(

Can you make a video on how to bug it and see it, because I don't fully understand it

Screen.Recording.2023-09-19.at.12.47.31.PM.mov

@productdevbook
Copy link
Member

Can you check everything, I think it's all working now.

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Sep 20, 2023

Can you check everything, I think it's all working now.

Yes, I think it's working well, except the styling. You're the best🥳

@Cr0zy07 Cr0zy07 marked this pull request as ready for review September 20, 2023 10:36
@productdevbook
Copy link
Member

You did a great job.

@productdevbook productdevbook merged commit 9256691 into oku-ui:main Sep 20, 2023
6 checks passed
This was referenced Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll Area
2 participants