Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: props struct #346

Merged
merged 20 commits into from
Sep 10, 2023
Merged

refactor: props struct #346

merged 20 commits into from
Sep 10, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Sep 10, 2023

Description

Linked Issues

cc #300

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook marked this pull request as draft September 10, 2023 10:39
@productdevbook productdevbook changed the title refactor: props refactor: props struct Sep 10, 2023
@productdevbook productdevbook marked this pull request as ready for review September 10, 2023 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.09% 5100 / 5924
🔵 Statements 86.09% 5100 / 5924
🔵 Functions 72.83% 177 / 243
🔵 Branches 84.1% 402 / 478
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/avatar/src/avatarImage.ts 100% 88.88% 100% 100%
packages/components/checkbox/src/bubbleInput.ts 54.44% 100% 0% 54.44% 44-84
packages/components/checkbox/src/checkbox.ts 86.63% 80% 72.72% 86.63% 130, 152-155, 178, 180-182, 190-196, 203-217
packages/components/checkbox/src/checkboxIndicator.ts 100% 77.77% 100% 100%
packages/components/collapsible/src/collapsible.ts 99.29% 94.44% 88.88% 99.29% 98
packages/components/collapsible/src/collapsibleContent.ts 79.77% 100% 50% 79.77% 62-79
packages/components/collapsible/src/collapsibleContentImpl.ts 61.98% 66.66% 50% 61.98% 57, 61, 65-88, 92-111
packages/components/collapsible/src/collapsibleTrigger.ts 100% 88.88% 100% 100%
packages/components/collection/src/collection.ts 99.36% 100% 100% 99.36% 116
packages/components/dismissable-layer/src/DismissableLayer.ts 47.26% 100% 0% 47.26% 142-305
packages/components/dismissable-layer/src/util.ts 72.04% 88.88% 50% 72.04% 38-79, 99-103, 139, 149-152
packages/components/focus-scope/src/focus-scope.ts 95.2% 71.79% 81.81% 95.2% 127, 158-165, 217, 241-242, 274-276
packages/components/label/src/label.ts 89.58% 100% 60% 89.58% 31-35
packages/components/popper/src/popper.ts 95.74% 66.66% 50% 95.74% 38-39
packages/components/portal/src/Portal.ts 98.48% 83.33% 100% 98.48% 59
packages/components/radio-group/src/BubbleInput.ts 55.42% 100% 0% 55.42% 41-77
packages/components/radio-group/src/Radio.ts 86.16% 82.35% 100% 86.16% 125-132, 138-151
packages/components/radio-group/src/RadioGroup.ts 100% 81.25% 100% 100%
packages/components/radio-group/src/RadioGroupIndicator.ts 100% 100% 100% 100%
packages/components/radio-group/src/RadioGroupItem.ts 83.33% 100% 57.14% 83.33% 68-70, 72-73, 81-82, 102-104, 107-108, 110-119
packages/components/radio-group/src/RadioIndicator.ts 100% 83.33% 100% 100%
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 78.88% 100% 14.28% 78.88% 83-84, 97, 100-101, 112-113, 115-116, 121-122, 136, 138, 141, 143-164, 167, 169
packages/components/roving-focus/src/RovingFocusGroupItem.ts 73.09% 88.88% 40% 73.09% 89-91, 109, 111-116, 119, 121, 124, 126-158
packages/components/separator/src/separator.ts 93.39% 87.5% 80% 93.39% 90-96
packages/components/switch/src/BubbleInput.ts 96.11% 60% 100% 96.11% 72-75
packages/components/switch/src/Switch.ts 98.24% 85.71% 88.88% 98.24% 136-138, 150
packages/components/switch/src/SwitchThumb.ts 60% 100% 0% 60% 31-54
packages/components/toggle/src/toggle.ts 98.59% 85% 88.88% 98.59% 97, 100
packages/core/use-composable/src/useEscapeKeydown.ts 100% 83.33% 100% 100%
Generated in workflow #838

@productdevbook productdevbook merged commit c23aa29 into main Sep 10, 2023
9 checks passed
@productdevbook productdevbook deleted the refactor-9-props branch September 10, 2023 11:26
This was referenced Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant