Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presence): close and open #362

Merged
merged 4 commits into from
Sep 19, 2023
Merged

fix(presence): close and open #362

merged 4 commits into from
Sep 19, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Sep 16, 2023

Description

  • more test
  • fixed all bugs
  • move tests folder
  • add more stories

Linked Issues

close #300

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.65% 6528 / 7363
🔵 Statements 88.65% 6528 / 7363
🔵 Functions 76.36% 223 / 292
🔵 Branches 88.47% 614 / 694
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/presence/src/presence.ts 100% 87.5% 100% 100%
packages/components/presence/src/usePresence.ts 76.02% 75% 71.42% 76.02% 48, 54-67, 81-91, 94-97, 121-122, 137-139
packages/components/presence/src/useStateMachine.ts 100% 100% 100% 100%
packages/components/presence/src/stories/Basic.vue 100% 100% 100% 100%
packages/components/presence/src/stories/Toggles.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithDeferredMountAnimation.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithMountAnimation.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithMultipleMountAnimations.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithMultipleOpenAndCloseAnimations.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithOpenAndCloseAnimation.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithUnmountAnimation.vue 100% 100% 100% 100%
packages/components/slot/src/slot.ts 100% 88.23% 100% 100%
packages/core/primitive/src/primitive.ts 100% 100% 100% 100%
Generated in workflow #883

@productdevbook productdevbook merged commit 6483999 into main Sep 19, 2023
10 checks passed
@productdevbook productdevbook deleted the fix-presence-1-23 branch September 19, 2023 03:53
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Presence) when change the display attribute of content, the animation can't work
1 participant