Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alert-dialog): new component #364

Merged
merged 14 commits into from
Sep 19, 2023
Merged

feat(alert-dialog): new component #364

merged 14 commits into from
Sep 19, 2023

Conversation

kbrkiras
Copy link
Contributor

Description

Linked Issues

#4

Additional context

@kbrkiras kbrkiras self-assigned this Sep 16, 2023
@kbrkiras kbrkiras linked an issue Sep 16, 2023 that may be closed by this pull request
Alert Dialog #4
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2023 •
edited

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.86% 8504 / 9359
🔵 Statements 90.86% 8504 / 9359
🔵 Functions 74.45% 274 / 368
🔵 Branches 89.59% 775 / 865
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/alert-dialog/src/alert-dialog-action.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/alert-dialog-cancel.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/alert-dialog-content.ts 93.67% 90% 60% 93.67% 49-50, 67-69
packages/components/alert-dialog/src/alert-dialog-description-warning.ts 40.54% 100% 0% 40.54% 12-33
packages/components/alert-dialog/src/alert-dialog-description.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/alert-dialog-overlay.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/alert-dialog-portal.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/alert-dialog-title.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/alert-dialog-trigger.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/alert-dialog.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/index.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/props.ts 100% 100% 100% 100%
packages/components/alert-dialog/src/stories/Controlled.vue 100% 88.88% 50% 100%
packages/components/alert-dialog/src/stories/Styled.vue 100% 100% 100% 100%
Generated in workflow #921

@productdevbook productdevbook marked this pull request as ready for review September 19, 2023 07:52
productdevbook
productdevbook approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@productdevbook productdevbook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@productdevbook productdevbook merged commit a9d0868 into main Sep 19, 2023
6 checks passed
@productdevbook productdevbook deleted the feat-alert-dialog branch September 19, 2023 08:15
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
@productdevbook productdevbook restored the feat-alert-dialog branch September 19, 2023 16:21
@productdevbook productdevbook deleted the feat-alert-dialog branch September 19, 2023 16:21
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dammy001 dammy001 dammy001 approved these changes

@productdevbook productdevbook productdevbook approved these changes

@YeSuX YeSuX YeSuX approved these changes

@Cr0zy07 Cr0zy07 Awaiting requested review from Cr0zy07

Assignees

@kbrkiras kbrkiras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert Dialog
4 participants
@kbrkiras @dammy001 @productdevbook @YeSuX