Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix stories css underscores #376

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

productdevbook
Copy link
Member

Description

Linked Issues

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook changed the title chore: fix underscores chore: fix stories css underscores Sep 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.86% 8504 / 9359
🔵 Statements 90.86% 8504 / 9359
🔵 Functions 74.45% 274 / 368
🔵 Branches 89.59% 775 / 865
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/alert-dialog/src/stories/Controlled.vue 100% 88.88% 50% 100%
packages/components/alert-dialog/src/stories/Styled.vue 100% 100% 100% 100%
packages/components/popper/src/stories/Animated.vue 100% 100% 100% 100%
packages/components/popper/src/stories/OneScroll.vue 100% 100% 100% 100%
packages/components/popper/src/stories/Styled.vue 100% 100% 100% 100%
packages/components/popper/src/stories/Transition.vue 100% 100% 100% 100%
packages/components/popper/src/stories/WithCustomArrow.vue 100% 100% 100% 100%
packages/components/popper/src/stories/WithPortal.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithDeferredMountAnimation.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithMountAnimation.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithMultipleMountAnimations.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithMultipleOpenAndCloseAnimations.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithOpenAndCloseAnimation.vue 100% 100% 100% 100%
packages/components/presence/src/stories/WithUnmountAnimation.vue 100% 100% 100% 100%
Generated in workflow #942

Copy link
Collaborator

@Cr0zy07 Cr0zy07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the Class from the end of each class

@productdevbook
Copy link
Member Author

Can we remove the Class from the end of each class

@Cr0zy07 i did

@productdevbook productdevbook merged commit 811febe into main Sep 20, 2023
6 checks passed
@productdevbook productdevbook deleted the chore-fix-underscores branch September 20, 2023 09:11
This was referenced Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants