Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(popover): more storybook and test add #393

Merged
merged 17 commits into from
Sep 30, 2023
Merged

chore(popover): more storybook and test add #393

merged 17 commits into from
Sep 30, 2023

Conversation

productdevbook
Copy link
Member

Description

Linked Issues

cc: #358

Additional context

@productdevbook productdevbook marked this pull request as draft September 30, 2023 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook changed the title refactor(popover): more storybook and test add chore(popover): more storybook and test add Sep 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.25% 11943 / 13233
🔵 Statements 90.25% 11943 / 13233
🔵 Functions 66.53% 342 / 514
🔵 Branches 91.16% 1052 / 1154
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/popover/src/index.ts 100% 100% 100% 100%
packages/components/popover/src/popover.ts 100% 100% 100% 100%
packages/components/popover/src/popoverAnchor.ts 100% 100% 100% 100%
packages/components/popover/src/popoverArrow.ts 100% 100% 50% 100%
packages/components/popover/src/popoverClose.ts 97.5% 100% 100% 97.5% 28
packages/components/popover/src/popoverContent.ts 90.69% 85.71% 100% 90.69% 30-33
packages/components/popover/src/popoverContentImpl.ts 87.5% 100% 45.45% 87.5% 44-45, 51-52, 54-55, 57-58, 60-61, 63-64
packages/components/popover/src/popoverContentModal.ts 33.78% 100% 0% 33.78% 19-67
packages/components/popover/src/popoverContentNonModal.ts 55.4% 100% 100% 55.4% 30-40, 43-64
packages/components/popover/src/popoverPortal.ts 100% 100% 100% 100%
packages/components/popover/src/popoverTrigger.ts 100% 100% 100% 100%
packages/components/popover/src/props.ts 100% 100% 66.66% 100%
packages/components/popover/src/utils.ts 100% 100% 100% 100%
packages/components/popover/src/stories/Animated.vue 100% 100% 100% 100%
packages/components/popover/src/stories/Boundary.vue 100% 100% 100% 100%
packages/components/popover/src/stories/Controlled.vue 100% 100% 100% 100%
packages/components/popover/src/stories/CustomAnchor.vue 100% 100% 100% 100%
packages/components/popover/src/stories/ForcedMount.vue 100% 100% 100% 100%
packages/components/popover/src/stories/Modality.vue 100% 100% 100% 100%
packages/components/popover/src/stories/Nested.vue 100% 100% 100% 100%
packages/components/popover/src/stories/VControlled.vue 100% 100% 100% 100%
packages/components/popover/src/stories/WithSlottedTrigger.vue 100% 100% 100% 100%
packages/core/popper/src/index.ts 100% 100% 100% 100%
packages/core/popper/src/popperContent.ts 100% 96% 100% 100%
packages/core/popper/src/stories/Transition.vue 100% 100% 100% 100%
packages/core/portal/src/Portal.ts 98.43% 80% 100% 98.43% 57
Generated in workflow #987

@productdevbook productdevbook marked this pull request as ready for review September 30, 2023 10:25
@dammy001 dammy001 merged commit cfc2fd8 into main Sep 30, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 30, 2023
@productdevbook productdevbook deleted the re-popover-props branch October 1, 2023 03:53
@github-actions github-actions bot mentioned this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants