Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix core packages render function #428

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

productdevbook
Copy link
Member

Description

Linked Issues

Additional context

Copy link
Contributor

github-actions bot commented Nov 25, 2023

Thank you for following the naming conventions! 🙏

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.96% 14429 / 16219
🔵 Statements 88.96% 14429 / 16219
🔵 Functions 60.3% 354 / 587
🔵 Branches 90.94% 1115 / 1226
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/arrow/src/arrow.ts 100% 100% 100% 100%
packages/core/collection/src/collection.ts 100% 100% 100% 100%
packages/core/dismissable-layer/src/DismissableLayer.ts 78.88% 85.71% 50% 78.88% 43-52, 56-65, 69-78, 142, 150-151, 154
packages/core/dismissable-layer/src/DismissableLayerBranch.ts 44.18% 100% 0% 44.18% 16-39
packages/core/focus-scope/src/focus-scope.ts 95.04% 75.6% 80% 95.04% 124, 155-162, 211, 235-236, 266-268
packages/core/menu/src/menu-anchor.ts 100% 100% 100% 100%
packages/core/menu/src/menu-group.ts 100% 75% 100% 100%
packages/core/menu/src/menu-item-impl.ts 45.61% 100% 100% 45.61% 44-46, 50-108
packages/core/menu/src/menu-item-indicator.ts 91.11% 100% 50% 91.11% 35-38
packages/core/menu/src/menu-label.ts 100% 75% 100% 100%
packages/core/menu/src/menu-separator.ts 100% 75% 100% 100%
packages/core/popper/src/popperAnchor.ts 97.95% 80% 100% 97.95% 34
packages/core/popper/src/popperArrow.ts 100% 70% 100% 100%
packages/core/popper/src/popperContent.ts 100% 95.91% 100% 100%
packages/core/portal/src/Portal.ts 98.3% 75% 100% 98.3% 54
packages/core/primitive/src/primitive.ts 100% 100% 100% 100%
packages/core/roving-focus/src/RovingFocusGroup.ts 100% 100% 100% 100%
packages/core/roving-focus/src/RovingFocusGroupImpl.ts 70.21% 100% 22.22% 70.21% 40-41, 54, 60-65, 75-76, 78-79, 84-85, 98, 100, 103, 105-126, 129, 131
packages/core/roving-focus/src/RovingFocusGroupItem.ts 64.28% 88.88% 100% 64.28% 46-47, 64, 66-71, 74, 76, 79, 81-113
packages/core/slot/src/slot.ts 100% 87.5% 100% 100%
packages/core/visually-hidden/src/VisuallyHidden.ts 100% 66.66% 100% 100%
Generated in workflow #1170

@productdevbook productdevbook marked this pull request as ready for review November 26, 2023 06:55
@productdevbook productdevbook changed the title refactor: core packages fix render function refactor: fix core packages render function Nov 26, 2023
@productdevbook productdevbook merged commit f5b1481 into main Nov 26, 2023
4 checks passed
@productdevbook productdevbook deleted the refactor-core-return branch November 26, 2023 06:55
@github-actions github-actions bot mentioned this pull request Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant