retry: Optimize for happy-path with until-loop

This simplifies and optimizes the retry command to only do the check for the number of left retries when actually needed.
okurz · Mar 23, 2022 · aacb70e · aacb70e
1 parent afbe4a4
commit aacb70e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/retry b/retry
@@ -3,8 +3,9 @@
 RETRIES="${RETRIES:-3}"
 SLEEP="${SLEEP:-3}"
 
-while [ "$RETRIES" -ge 0 ] ; do
-    # shellcheck disable=SC2048
+# shellcheck disable=SC2048
+until $*; do
+    [ "$RETRIES" -ge 0 ] || break
     $* && break
     echo "Retrying up to $RETRIES more times after sleeping ${SLEEP}s …"
     RETRIES=$((RETRIES-1))