Subviews #32
Merged
Subviews #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 138 141 +3
Branches 14 15 +1
=====================================
+ Hits 138 141 +3
Continue to review full report at Codecov.
|
okwolf
commented
Mar 10, 2018
package.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| "babel-preset-env": "^1.6.1", | |||
| "eslint": "^4.18.2", | |||
| "eslint-plugin-compat": "^2.2.0", | |||
| "hyperapp": "^1.1.2", | |||
| "hyperapp": "hyperapp/hyperapp", | |||
There was a problem hiding this comment.
Remember to change this when the official release is made.
package.json
Outdated
| @@ -30,7 +30,8 @@ | |||
| "bundle": "rollup -i src/index.js -o dist/fx.js -m -f umd -n fx", | |||
| "minify": "uglifyjs dist/fx.js -o dist/fx.js -mc pure_funcs=['Object.defineProperty'] --source-map includeSources,url=fx.js.map", | |||
| "check": "npm run format:check && npm run lint && npm t", | |||
| "build": "npm run check && npm run bundle && npm run minify", | |||
| "build:hyperapp": "cd node_modules/hyperapp && npm i && npm run bundle", | |||
There was a problem hiding this comment.
Remove this when pulling in new release.
test wasn't well written and led me astray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting lazy components/subviews by wiring them in as-needed.