Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateTxCount only when there is cosmos tx in block & fix vmbridge smb #3152

Merged
merged 6 commits into from Jun 5, 2023

Conversation

LeoGuo621
Copy link
Contributor

@LeoGuo621 LeoGuo621 commented May 26, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #3152 (910a6d6) into dev (006c451) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 910a6d6 differs from pull request most recent head fee5bd7. Consider uploading reports for the commit fee5bd7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3152   +/-   ##
=======================================
  Coverage   36.58%   36.59%           
=======================================
  Files         442      442           
  Lines       46428    46430    +2     
=======================================
+ Hits        16988    16990    +2     
  Misses      28179    28179           
  Partials     1261     1261           
Impacted Files Coverage Δ
x/wasm/types/types.go 39.80% <0.00%> (-0.41%) ⬇️

... and 1 file with indirect coverage changes

@LeoGuo621 LeoGuo621 requested a review from scf0220 June 2, 2023 02:20
@LeoGuo621 LeoGuo621 marked this pull request as draft June 2, 2023 02:26
@LeoGuo621 LeoGuo621 changed the title UpdateTxCount only when there is cosmos tx in block UpdateTxCount only when there is cosmos tx in block & fix vmbridge smb Jun 2, 2023
@LeoGuo621 LeoGuo621 marked this pull request as ready for review June 5, 2023 10:39
@KamiD KamiD merged commit 8476382 into dev Jun 5, 2023
8 checks passed
@LeoGuo621 LeoGuo621 deleted the leo/fix-testnet-smb branch June 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants