Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sound mode "DOLBY PRO LOGIC" #270

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add sound mode "DOLBY PRO LOGIC" #270

merged 1 commit into from
Jan 3, 2024

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG mentioned this pull request Dec 12, 2023
Closed
@ol-iver
Copy link
Owner

ol-iver commented Jan 3, 2024

Thanks 😄

@ol-iver ol-iver merged commit 79215e4 into ol-iver:main Jan 3, 2024
6 checks passed
@xconverge
Copy link
Contributor

@ol-iver I saw this log message in my HA instance, should I open a separate PR with a similar change? I am also ok to just let it fallback since it is right...

Logger: denonavr.soundmode
Source: components/denonavr/media_player.py:362
First occurred: January 1, 2024 at 1:23:02 PM (1 occurrences)
Last logged: January 1, 2024 at 1:23:02 PM

Not able to match sound mode: 'DOLBY PLII GAME', assuming 'DOLBY DIGITAL'.

@xconverge
Copy link
Contributor

There is also this one, so sounds like yes I should open a PR #268

@starkillerOG starkillerOG deleted the patch-27 branch January 3, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@starkillerOG @ol-iver @xconverge