Skip to content

Commit

Permalink
Warn on empty instance name instead of failure. (bazelbuild#115)
Browse files Browse the repository at this point in the history
  • Loading branch information
arberx authored and Ola Rozenfeld committed Jan 14, 2020
1 parent e549ae4 commit 6e44b2e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/pkg/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func DialRaw(ctx context.Context, params DialParams) (*grpc.ClientConn, error) {
// functionality.
func NewClient(ctx context.Context, instanceName string, params DialParams, opts ...Opt) (*Client, error) {
if instanceName == "" {
return nil, fmt.Errorf("instance needs to be specified")
log.Warning("Instance name was not specified.")
}
if params.Service == "" {
return nil, fmt.Errorf("service needs to be specified")
Expand Down

0 comments on commit 6e44b2e

Please sign in to comment.