Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/core and recreate lockfile #4

Closed
wants to merge 1 commit into from

Conversation

cb372
Copy link

@cb372 cb372 commented Oct 19, 2020

Bumping the actions/core dependency to fix the "add-path command is deprecated" warning when running the action.

I had to delete and recreate the lockfile because it was full of artifactory.twitter.biz URLs that I couldn't resolve. You might want to recreate it on your machine.

Bumping the actions/core dependency to the "`add-path` command is
deprecated" warning when running the action.

I had to delete and recreate the lockfile because it was full of
`artifactory.twitter.biz` URLs that I couldn't resolve. You might want
to recreate it on your machine.
Copy link
Owner

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! This was long overdue. I took the liberty to update the dependencies locally and push to master. Will cut a new release.

The twitter.biz URLs come from a ~/.yarnrc file on my local computer. It's updated daily so I need to remember to remove it every time I run yarn install and it's easy to forget 😅

@olafurpg olafurpg closed this Oct 19, 2020
@olafurpg
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants