Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have InsertLine take a size_t (and pragma 4018 removal) #12

Closed
GoogleCodeExporter opened this issue Mar 12, 2015 · 3 comments
Closed

have InsertLine take a size_t (and pragma 4018 removal) #12

GoogleCodeExporter opened this issue Mar 12, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Noticed the following comment in template.cc:
// TODO(csilvers): have InsertLine take a size_t

I took a stab at it and figured it would be worthwhile to trace through the
warnings suppressed by pragma 4018 as well.

Original issue reported on code.google.com by josepharmbruster@gmail.com on 15 Nov 2007 at 3:00

Attachments:

@GoogleCodeExporter
Copy link
Author

Note:

line 210 of template_regtest.cc will need repair

Original comment by josepharmbruster@gmail.com on 15 Nov 2007 at 3:07

@GoogleCodeExporter
Copy link
Author

Cool, thanks for taking the time to do this.  I'll use this patch as the basis 
for
some more type fixups, which we should expect to see in the next release.

Original comment by csilv...@gmail.com on 15 Nov 2007 at 8:06

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

This should be fixed in ctemplate 0.9, which was just released.

Original comment by csilv...@gmail.com on 25 Jan 2008 at 8:32

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant