refactor out forEachObject and forEachAttribute

TODO.md

@@ -1,2 +1,4 @@
 * setAttribute
 * cloneNode
+* expand conversion combinators
+* add benchmarks

lib/Element/core.js

@@ -10,13 +10,6 @@ var arrayInstanceOf = function (arr, Class) {
   return arr instanceof Array && (arr.length === 0 || arr[0] instanceof Class);
 };
 
-var forEachObject = function (obj, fn) {
-  for (var key in obj) {
-    if (!obj.hasOwnProperty(key)) { continue; }
-    fn(key, obj[key]);
-  }
-};
-
 // validate
 var validateType = function (type, validTypes) {
   var elTypes = INHERIT[type];
@@ -81,7 +74,9 @@ var Element = module.exports = function (parentElement, parentAttribute, ast) {
   }
 
   // copy ast information onto object
-  forEachObject(ast, function (attr, value) {
+  Object.keys(ast).forEach(function (attr) {
+    var value = ast[attr];
+
     if (typeof value === "object") {
       if (value instanceof Array) {
         if (value.length === 0) {
@@ -120,20 +115,11 @@ var Element = module.exports = function (parentElement, parentAttribute, ast) {
   }.bind(this));
 };
 
-// private
-Element.prototype._forEachAttribute = function (fn) {
-  var exclude = ["parentElement", "parentAttribute"];
-
-  forEachObject(this, function (attr, value) {
-    if (exclude.indexOf(attr) === -1) { fn(attr, value); }
-  });
-};
-
 // children
 Element.prototype.childElements = function () {
   var children = [];
 
-  forEachObject(ATTR[this.type], function (attr) {
+  Object.keys(ATTR[this.type]).forEach(function (attr) {
     var value = this[attr];
     if (arrayInstanceOf(value, Element)) {
       children = children.concat(value);
@@ -322,7 +308,13 @@ Element.prototype.replaceChild = function (newChild, oldChild) {
 Element.prototype.outerAST = function () {
   var element = {};
 
-  this._forEachAttribute(function (attr, value) {
+  element.type = this.type;
+  element.loc = this.loc;
+  element.comments = this.comments;
+
+  Object.keys(ATTR[this.type]).forEach(function (attr) {
+    var value = this[attr];
+
     if (arrayInstanceOf(value, Element)) {
       element[attr] = value.map(function (v) {
         return v.outerAST();
@@ -336,7 +328,7 @@ Element.prototype.outerAST = function () {
     }
 
     element[attr] = value;
-  });
+  }.bind(this));
 
   if (this.recastPrelude !== null && this.parentElement === null) {
     this.recastPrelude.program = element;