fix bug when there are multiple children of variant

olahol · Mar 5, 2015 · 83a2692 · 83a2692
1 parent e2de489
commit 83a2692
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 0.3.1 (2015-01-23)
+
+* Fix bug when there are multiple children och Variant.
+
 ### 0.3.0 (2015-01-23)
 
 * Add random prop.

diff --git a/bower.json b/bower.json
@@ -3,7 +3,7 @@
   "main": [
     "react-ab.js"
   ],
-  "version": "0.3.0",
+  "version": "0.3.1",
   "homepage": "https://github.com/olahol/react-ab",
   "description": "Simple isopmorphic A/B testing component for React.",
   "keywords": [

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-ab",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Simple isopmorphic A/B testing component for React.",
   "main": "react-ab.js",
   "dependencies": {

diff --git a/react-ab.js b/react-ab.js
@@ -66,7 +66,11 @@
     }
 
     , render: function () {
-      return this.props.children;
+      if (React.Children.count(this.props.children) === 1) {
+        return this.props.children;
+      }
+
+      return React.createElement("span", null, this.props.children);
     }
   });
 

diff --git a/test/index.js b/test/index.js
@@ -18,9 +18,13 @@ var Experiment = require("../react-ab").Experiment
   , Variant = require("../react-ab").Variant;
 
 describe("Experiment", function () {
-  var createExperiment = function (name, choice, variants) {
+  var createExperiment = function (name, choice, variants, factory) {
+    factory = factory || function (variant) {
+      return React.createElement("span", null, variant);
+    };
+
     var variantNodes = variants.map(function (variant) {
-      return React.createElement(Variant, { key: variant, name: variant }, React.createElement("span", null, variant));
+      return React.createElement(Variant, { key: variant, name: variant }, factory(variant));
     });
 
     return TestUtils.renderIntoDocument(React.createElement(Experiment, { name: name, onChoice: choice }, variantNodes));
@@ -87,4 +91,12 @@ describe("Experiment", function () {
 
     assert.equal(ex4.getVariant(), ex5.getVariant());
   });
+
+  it("should work when variants have multiple children", function () {
+    var variant1 = React.createElement(Variant, { name: "one" }, React.createElement("span", null, ""), React.createElement("span", null, ""));
+    var variant2 = React.createElement(Variant, { name: "two" }, React.createElement("span", null, ""), React.createElement("span", null, ""));
+    var ex = TestUtils.renderIntoDocument(React.createElement(Experiment, { name: "test", onChoice: function () { }}, variant1, variant2));
+
+    assert.ok(ex);
+  });
 });