Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pg version to support latest node (tested on node 14.11.0) #21

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

sohel-ahmed-ansari
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Oct 6, 2020

Coverage Status

Coverage remained the same at 88.889% when pulling bd88821 on sohel-ahmed-ansari:master into a28c1a0 on olalonde:master.

@vtdiep vtdiep mentioned this pull request Oct 20, 2020
@EyePulp
Copy link

EyePulp commented Oct 29, 2020

@olalonde I was having the same problems under node v14 -- this PR fixed the problem nicely.

Thanks @sohel-ahmed-ansari !

@rbadr
Copy link

rbadr commented Nov 5, 2020

Hello @olalonde 👋
Any update on this one ? 🙏

@adriaandotcom
Copy link
Collaborator

If this will be merged the support for Node.js 5 will be dropped. I think the world can live with that :)

@norkator
Copy link

What happened to the owner of this repository? should repo owner give someone else write access? so that could check and merge these fixes because this is surprisingly handy package.

@adriaandotcom
Copy link
Collaborator

adriaandotcom commented Mar 1, 2021

I know this is an old PR, but would love to merge it after the tests will succeed. @sohel-ahmed-ansari would you mind removing Node.js 5 from the travis file?

- "5"

... should repo owner give someone else write access? ...

I do have access now, feel free to ping me if something needs attention. I'm also welcoming all the help I can get. For example would love to move the tests to GitHub Actions and add more tests to this library.

@adriaandotcom
Copy link
Collaborator

I removed Node.js 5 on master, so if you pull in the latest master you should be good to go.

@sohel-ahmed-ansari
Copy link
Author

sohel-ahmed-ansari commented Mar 1, 2021

Thanks @adriaanvanrossum. I have merged latest from master. This PR can be merged now

@adriaandotcom adriaandotcom merged commit e919948 into olalonde:master Mar 2, 2021
@adriaandotcom
Copy link
Collaborator

adriaandotcom commented Mar 2, 2021

Thank you, merged and published to NPM as v0.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants