Merge pull request #34 from sudo-bmitch/pr-mem-blob-create-race

Fix a race in mem.BlobCreate
olareg · Dec 25, 2023 · 357bcc4 · 357bcc4
2 parents cf73c51 + e5fc93d
commit 357bcc4
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/internal/store/mem.go b/internal/store/mem.go
@@ -133,7 +133,10 @@ func (mr *memRepo) BlobCreate(opts ...BlobOpt) (BlobCreator, error) {
 	}
 	// if blob exists, return the appropriate error
 	if conf.expect != "" {
-		if _, ok := mr.blobs[conf.expect]; ok {
+		mr.mu.Lock()
+		_, ok := mr.blobs[conf.expect]
+		mr.mu.Unlock()
+		if ok {
 			return nil, types.ErrBlobExists
 		}
 	}