Fix: Logging of delete by tag and copying descriptors #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Debug logging of a tag deletion does not show the tag annotation.
Describe the change
The descriptor was not copied, resulting in the deletion from the index overwriting the descriptor that was being logged. This fixes the
Index.GetDesc
call to always return a copy, and it fixes the copy to clone the annotations. This also improves the testing around GC.How to verify it
Changelog text
Please verify and check that the pull request fulfills the following requirements