Test using isAssignableFrom instead of by class

This will handle ExtendedBioclipseJob too. I can not run tests on my machine but this should-be-safe™. Fixes bug: #1659
olas · Oct 20, 2009 · deddc5e · deddc5e
1 parent e743091
commit deddc5e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...t.bioclipse.core/src/net/bioclipse/managers/business/AbstractManagerMethodDispatcher.java b/...t.bioclipse.core/src/net/bioclipse/managers/business/AbstractManagerMethodDispatcher.java
@@ -99,8 +99,10 @@ public Object invoke( MethodInvocation invocation ) throws Throwable {
         }
 
         Object returnValue;
-        if ( (invocation.getMethod().getReturnType() != BioclipseJob.class &&
-             invocation.getMethod().getReturnType() != void.class)
+        if ( ( !BioclipseJob.class
+                            .isAssignableFrom( invocation.getMethod()
+                                                         .getReturnType() ) 
+               && invocation.getMethod().getReturnType() != void.class )
              || Arrays.asList( invocation.getMethod().getParameterTypes() )
                       .contains( IProgressMonitor.class ) ) {
             if ( Arrays.asList( m.getParameterTypes() )