Fix parsing transparent errors with no attributes. Apply new error at…

…tribute parsing to non-transparent post errors. Bump version to 0.4.4.

lib/recurly/base.rb

@@ -27,7 +27,12 @@ def save
     rescue ActiveResource::ResourceInvalid => error
       case error.response['Content-Type']
       when /application\/xml/
-        errors.from_xml(error.response.body)
+        begin
+          f = Recurly::Formats::XmlWithErrorsFormat.new
+          load_errors_from_array(f.decode(error.response.body))
+        rescue
+          errors.from_xml(error.response.body)
+        end
       when /application\/json/
         errors.from_json(error.response.body)
       end
@@ -103,8 +108,8 @@ def load_errors_from_array(new_errors, save_cache = false)
               errors[:base] << message
             end
 
-            humanized_name = field.humanize
-            message = message[(humanized_name.size + 1)..-1] if message[0, humanized_name.size + 1] == "#{humanized_name} "
+            humanized_name = field.humanize.downcase
+            message = message[(humanized_name.size + 1)..-1] if message[0, humanized_name.size + 1].downcase == "#{humanized_name} "
 
             errors.add field.to_sym, message
           elsif error.is_a?(String)

lib/recurly/formats/xml_with_errors.rb

@@ -32,7 +32,7 @@ def xml_node_to_hash(node)
         elsif node_type == 'array'
           return node.children.collect do |child|
             xml_node_to_hash(child)
-          end
+          end.reject { |n| n.nil? || (n.is_a?(String) && n.blank?) }
         end
 
         return nil if node.children.empty?
@@ -92,7 +92,7 @@ def xml_node_type(node)
       end
 
       def xml_attributes(node)
-        return nil if node.attribute_nodes.empty?
+        return {} if node.attribute_nodes.empty?
         values = {}
         node.attribute_nodes.each do |attribute|
           values[attribute.name] = attribute.value

lib/recurly/version.rb

@@ -1,3 +1,3 @@
 module Recurly #:nodoc
-  VERSION = "0.4.3"
+  VERSION = "0.4.4"
 end

spec/integration/account_spec.rb

@@ -219,8 +219,8 @@ module Recurly
         end
 
         it "should require setting an account code" do
-          @account.errors[:base].should include("account code can't be blank")
-          @account.errors[:base].should include("account code is invalid")
+          @account.errors[:account_code].should include("can't be blank")
+          @account.errors[:account_code].should include("is invalid")
         end
       end
 
@@ -237,7 +237,7 @@ module Recurly
         end
 
         it "should require setting an account code" do
-          @account.errors[:base].should include("account code has already been taken")
+          @account.errors[:account_code].should include("has already been taken")
         end
       end
     end