Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex comparisons work differently in Ruby 2.7 #213

Closed
olbrich opened this issue Dec 28, 2020 · 0 comments · Fixed by #214
Closed

Complex comparisons work differently in Ruby 2.7 #213

olbrich opened this issue Dec 28, 2020 · 0 comments · Fixed by #214
Assignees
@olbrich
Labels
bug maintenance
Milestone
Version 2.3.2

Comments

@olbrich
Copy link
Owner

olbrich commented Dec 28, 2020

Prior to Ruby 2.7, the Complex class did not implement a :<=> method, which requires some special handling. This was changed in 2.7.
See https://bugs.ruby-lang.org/issues/15857 and https://rubyreferences.github.io/rubychanges/2.7.html#complex
@olbrich olbrich self-assigned this Dec 28, 2020
olbrich added a commit that referenced this issue Dec 28, 2020
@olbrich
Complex comparisons work differently in Ruby 2.7
8179485 
Fixes #213
@olbrich olbrich mentioned this issue Dec 28, 2020
Merged
olbrich added a commit that referenced this issue Dec 28, 2020
@olbrich
Complex comparisons work differently in Ruby 2.7 (#214)
31c30b2 
* Complex comparisons work differently in Ruby 2.7
Fixes #213
@olbrich olbrich added this to the Version 2.3.2 milestone Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olbrich olbrich

Labels
bug maintenance
Projects
None yet
Milestone
Version 2.3.2
Development

Successfully merging a pull request may close this issue.

Complex comparisons work differently in Ruby 2.7 olbrich/ruby-units
1 participant
@olbrich