-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds logo and favicon. #40
Conversation
So this looks nice. However, from a UI perspective, the logo says "OLCF ..." but actually links to documentation homepage. Confusing? |
Hm. That's a good point. Maybe we could add a "back to olcf.ornl.gov" button? I think the action of clicking on the RTD logo area should keep a user inside of the docs, but am open to being convinced otherwise. |
yeah, it is obviously standard for the RTD theme for the icon to take you to the home page, so probably want to keep that. I wonder if we can change the logo image so that is more clear, and we'll have backlinks to OLCF elsewhere in the page(s) |
I'd be in favor of putting backlinks to olcf.ornl.gov in place of I asked @tom-papatheodore about this and he also suggested a change to the logo graphic. |
sounds fine to me |
…jack-morrison/issue6
…acked way to get a link back to olcf.ornl.gov
@grahamlopez so, it's pretty hacky, but what do you think of the If this type of custom javascript + CSS injection isn't the business we want to be in, we can drop this altogether. I'm trying to: While this approach uses |
Closing, as this work (and other header/footer integration) is being picked up by Brian Gajus. |
Fixes #6