Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logo and favicon. #40

Closed
wants to merge 4 commits into from

Conversation

jack-morrison
Copy link
Contributor

@jack-morrison jack-morrison commented Sep 9, 2019

Fixes #6

@jack-morrison jack-morrison changed the title Fixes #6; Also adds a favicon. Adds logo and favicon. Sep 9, 2019
@grahamlopez
Copy link
Contributor

So this looks nice. However, from a UI perspective, the logo says "OLCF ..." but actually links to documentation homepage. Confusing?

@jack-morrison
Copy link
Contributor Author

Hm. That's a good point. Maybe we could add a "back to olcf.ornl.gov" button? I think the action of clicking on the RTD logo area should keep a user inside of the docs, but am open to being convinced otherwise.

@grahamlopez
Copy link
Contributor

yeah, it is obviously standard for the RTD theme for the icon to take you to the home page, so probably want to keep that. I wonder if we can change the logo image so that is more clear, and we'll have backlinks to OLCF elsewhere in the page(s)

@jack-morrison
Copy link
Contributor Author

I'd be in favor of putting backlinks to olcf.ornl.gov in place of View Page Source in the top right of all pages.

I asked @tom-papatheodore about this and he also suggested a change to the logo graphic.

@grahamlopez
Copy link
Contributor

sounds fine to me

@jack-morrison jack-morrison changed the title Adds logo and favicon. [WIP] Adds logo and favicon. Sep 9, 2019
@jack-morrison
Copy link
Contributor Author

jack-morrison commented Sep 12, 2019

@grahamlopez so, it's pretty hacky, but what do you think of the Back to OLCF.ORNL.GOV in the left hand nav? I know it adds some matching body text, but that can be hidden with some CSS.

If this type of custom javascript + CSS injection isn't the business we want to be in, we can drop this altogether. I'm trying to:
[1] Maintain that clicking the RTD logo area keeps you inside the docs.
[2] Maintain the upper right 'Show page source' text, since a future issue could address adding GitHub integrations there (like Spack's RTD)
[3] Provide a user-friendly and obvious way to get back to the OLCF homepage.

While this approach uses :caption:, it shouldn't bar us from using :caption: elsewhere since the styles are only applied to specific caption elements.

@jack-morrison
Copy link
Contributor Author

Closing, as this work (and other header/footer integration) is being picked up by Brian Gajus.

@jack-morrison jack-morrison changed the title [WIP] Adds logo and favicon. Adds logo and favicon. Sep 23, 2019
@jack-morrison jack-morrison deleted the jack-morrison/issue6 branch September 30, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OLCF logo to left-hand navigation
2 participants