support on python3 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert type(width) in (int, long, float) | ||
| assert type(height) in (int, long, float) | ||
| assert type(width) in (int, int, float) | ||
| assert type(height) in (int, int, float) |
There was a problem hiding this comment.
诶～～这样 Python 2 会不会有问题？可以用 six.integer_types
There was a problem hiding this comment.
是有问题。不过很少有 Pull Request，所以先接受，再修改。XD
不过用six的话，会让这个库多一个依赖，似乎也最好避免...
There was a problem hiding this comment.
多谢！还有一个地方，base背景的地方，判断路径有Unicode，python3使用时也会有问题，稍后再提交！
发自我的 iPad
在 2014年10月19日，19:05，oldj notifications@github.com 写道：
In pyheatmap/heatmap.py:
@@ -30,8 +30,8 @@ def init(self,
assert type(data) in (list, tuple) assert base is None or os.path.isfile(base)
assert type(width) in (int, long, float)assert type(height) in (int, long, float)assert type(width) in (int, int, float)assert type(height) in (int, int, float)
不过用six的话，会让这个库多一个依赖，似乎也最好避免...—
Reply to this email directly or view it on GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support on python3.4