This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Foundation update #1022
Merged
Foundation update #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Awesome! Great work. |
|
Thanks a lot @olefredrik |
|
Awesome! Merci! |
|
Thank you @olefredrik for the great work done. |
|
So far so good, did an update, did another npm install and everything is still working 馃憤 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so here it is. FoundationPress is now based on Foundation 6.4.1. That means we've got a new (and better way) for writing and using layouts with XY-Grid. The old float based grid is disabled by default, but is still a part of the project if you need to support legacy browsers. JavaScript is now bundled and loaded with webpack. And a lot of issues are addressed. I think that it has generally become a better and more robust theme.
We have removed some dependencies like bower. As a consequence of the changes that was introduced in Foundation 6.4.1, the Gulpfile is also changed. This is more or less copied from the Zurb Template, with only a few adjustments to make it work in a WordPress context.
Last but now least, the README file is obviously updated with the new instructions.
Enjoy! 馃殌