Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Small fixes #1161

Merged
merged 5 commits into from Nov 21, 2017
Merged

Small fixes #1161

merged 5 commits into from Nov 21, 2017

Conversation

emaia
Copy link
Contributor

@emaia emaia commented Nov 20, 2017

Changes:

  • Removed unused icon images no longer needed since WP 4.3 (missed in remove favicon #784).
  • Corrected typo in comment FontAwesome comment.
  • Changed img to images in gulp watch task path in gulpfile.babel.js (Missed in Tiny update gulpfile.babel.js #1155).
  • Removed unnecessary echoes in front of the_post_thumbnail_url function.
  • Removed unnecessary/invalid fourth parameter in remove_action calls in library/cleanup.php.

@emaia emaia changed the title Remove unused images (missed in #784) Small fixes Nov 20, 2017
@colin-marshall
Copy link
Collaborator

@emaia congratulations on your first FoundationPress contribution(s)! All look good to me.

For future reference, please add a description to your pull requests outlining the changes. I did it for you on this one.

Thanks for the PR!

@emaia
Copy link
Contributor Author

emaia commented Nov 21, 2017

@colin-marshall I'm happy to contribute with the FP. Thanks for add a description. I will do this in the next PR.

@olefredrik olefredrik merged commit 762d872 into olefredrik:master Nov 21, 2017
@olefredrik
Copy link
Owner

Looks good 👌 Thanks, @emaia and @colin-marshall !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants