This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Improvements + Consistency updates in code indentation across multiple php files #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2017 15:47
- Update 404.php indentation to keep it consistent across theme - Remove extra new lines on front.php - Update kitchen-sink.php indenting across entire template to make it more readable - Update indenting on function call in mobile-off-canvas.php / mobile-topbar.php to keep consistent
| <?php endwhile;?> | ||
| </main> | ||
| <?php get_sidebar(); ?> | ||
| <main class="main-content"[> |
There was a problem hiding this comment.
@giollianosulit it looks like you accidentally added a left bracket on this line?
|
@colin-marshall , yeah just noticed that in issue #1172 (example code ended up being posted there with the stray ']'. I've pushed an update, how would a revision to a pull request normally work ? A new pull request or would it be apart of the same one ? |
|
@giollianosulit I guess normally we would revert the commit (as described in https://stackoverflow.com/a/16298304/2755888) but for a single typo it's probably easiest to just create a new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has improvements over a few files to keep the indenting + code formatting consistent across the theme.
Relates to issue: #1172