This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Fix footer container. #1180 #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,11 +1,10 @@ | |||
| .footer-container { | |||
There was a problem hiding this comment.
@JPOak do you think we should add a .footer selector before here and just make the background-color transparent or white by default? The background color is the whole reason we were opting for option 2 after all.
|
@colin-marshall I'll let you make the call on that. I'm happy to make the change. For me, it's just having the structural option there. It would not have to be as opinionated for me. |
|
@olefredrik what do you think? |
|
@colin-marshall This PR has been sitting here for awhile. Should I just withdraw it? Or change it? Just let me know. I like to clean up after myself : ) . |
|
Sorry @JPOak, was hoping for more feedback on what I proposed. Let's just get it merged for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
Note: I did not add a background color to ".footer" . I felt you should leave to the dev to decide whether to leave transparent or what have you. The structure is the important thing.