Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Update package.json #1327

Merged
merged 2 commits into from Nov 8, 2018
Merged

Conversation

dantahoua
Copy link
Contributor

Change version of Gulp for install regarding issue #1322

Before opening a pull request, please make sure to do the following:

Open an issue related to the bugfix/feature addressed in the pull request, if one does not already exist.

Make it clear in your commit messages what is being changed, and the reason for the changes.

Change version of Gulp for install regarding issue olefredrik#1322
@olefredrik
Copy link
Owner

I agree with @derweili 's comment in #1322

I don't think "next" is the right version to reference. "next" does not reference to a unique version but to the latest stable version. This version will change in the future. Using "next" could cause incompatibility problems when gulp has breaking changes in upcoming versions.

It seems to be a better idea to change it to "gulp": "^4.0"

If you agree that this might be a better approach, please update your pull request and I'll merge it into the master branch.

Thanks!

@dantahoua
Copy link
Contributor Author

No problem! You're right! I'll update it right now. :)

@olefredrik olefredrik merged commit 3fa0409 into olefredrik:master Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants