Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon too big on nested context menu #12

Closed
Fantazzj opened this issue Apr 6, 2022 · 3 comments
Closed

Icon too big on nested context menu #12

Fantazzj opened this issue Apr 6, 2022 · 3 comments
Labels
Done question Further information is requested

Comments

@Fantazzj
Copy link

Fantazzj commented Apr 6, 2022

When I put an icon for the nested context menu it appears to big.

The problem
immagine

The folder of the configuration:
immagine

I'm using the one it is included with the software, i've tried even with different icons from 32x32 and bigger, but the same happens.
I'm ond windows 10 and used chocolatey to install shell-x.

@oleg-shilo
Copy link
Owner

Not sure I have too many options to address it.

The icon file is taken as is and assigned to the standard .NET WinForms menu item:

var menu = new ToolStripMenuItem
           {
               Text = item.ToFileMenuText(),
               Image = LookupImageFor(item)
           };

Thus the extension itself does not participate in the menu rendering. Thus there is no mechanism to change the rendering algorithm.

I am guessing there is something tricky with your monitor resolution and scaling. Under normal circumstances, as you can see the very same icon works just fine:

image

Not sure what can be done if you have to keep your calling. Maybe you can just develop your custom icon if the benefit is worth the effort.

@oleg-shilo oleg-shilo added the question Further information is requested label Apr 7, 2022
@Ahernz
Copy link

Ahernz commented Nov 30, 2022

I also found this problem today. For icons of the same size, the icon of the file in the right-click menu will be smaller than the icon of the folder.
2022-12-01_00-17-22

oleg-shilo added a commit that referenced this issue Jan 6, 2023
- Issue #12: Icon too big on nested context menu
@oleg-shilo
Copy link
Owner

Sorry for the late response. Indeed there was a mistake in the image assignment algorithm for folders.
Fixed in the Release v1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants