Incorrect context menu

[GibMeMyPacket]

Hello,
using [srt,mkv,mp4] folder to add context menu for srt, mkv and mp4 files.
But it is showing the context menu everywhere!

[oleg-shilo]

I am investigating it. Thank you

[oleg-shilo]

Fixed.
I will also address #22 and will release it. (most likely in a day or two)

[oleg-shilo]

Published on Chocolatey: https://community.chocolatey.org/packages/shell-x/1.5.3.0

Will be available as soon as Chocolatey moderation is done

[masterofobzene]

Found a bug on the new release, if you set the folder as for example [mp4,mov,mpg,mpeg,avi,mkv,webm,webp,bmp,jpeg,jpg,tiff,gif] and select many files (like all jpg's) the menu doesn't show.

It does work with [any]

[oleg-shilo]

Please try now

[masterofobzene]

Please try now

Same behaviour, doesn't work when selecting more than one item.

[oleg-shilo]

---

Is it possible that your explorer did not restart after the upgrade?

[masterofobzene]

Try selecting diferent extension files and see if it works for you please I found that the problem happens when you select different extension files

here is my config folder:
[mp4,mov,mpg,mpeg,avi,mkv,webm,webp,bmp,jpeg,jpg,tiff,gif]

Selecting two different (but allowed) extensions causes the menu to not show up.

[oleg-shilo]

Strange...

[masterofobzene]

In the video you can see that when selecting different extensions the menu doesn't show up. I'm on Windows 10, don't know you (using the legacy menu?).

Also I noted you still have enabled the [any] folder, could that be causing it to work? do you have anything in that folder?

2023-03-23.10-04-36.mp4

---

[masterofobzene]

EDIT: BINGO! it was because I disabled the [any] folder. What needs to be done is to leave an empty [any] folder to make it work with different extensions, otherwise when you select many filetypes the menu will not be shown.

[oleg-shilo]

Also I noted you still have enabled the [any] folder

Correct. [any] is required to give the user convenient access to the shell-x configuration folder:

Saying that, the dependency on [any] is not intentional. I will address it but until then (as a workaround) please keep [any] enabled.

[masterofobzene]

Just found another bug: on long filenames (230 characters), the menu is not being shown.
(I'm not naming the files like that, they come named like that from internet)

[oleg-shilo]

It is a limitation of the operating system.
IE you cannot even create a file with such a long name (248 chars) if you are using .NET for that.

[masterofobzene]

Weird cause I've patched the system to allow long names... in fact they are being shown and can rename them in the explorer. Anyway I take it as a limitation and not a bug.

[oleg-shilo]

The MAX_PATH limitation has been known for more than a decade.
Though it's not a universal quality of WIN file system but only one of its subsystems (eg explorer).
To add even more confusion to this, consider the fact that I have two Win10 systems (different builds) where one has the code above failing to create the file and another one successfully creating it. However in this case the shell extension is failing even to start.

Only some applications, that can act on a very low level of file system can overcome this problem because the limit is imposed on file creation but not renaming (afaik).

You also can enable Win32 long path support from group policy, providing you have permission.
Then it is expected that all IO libraries will start supporting long-names.

Anyway, Win is still suffering from this problem so its' problematic to address it from the application like shell-x.