Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stylelint and its dependencies to 14.0.1 #138

Closed
wants to merge 15 commits into from

Conversation

ronilaukkarinen
Copy link

This updates packages, adds changelog etc.

- "12"
- "10.12.0"
- "15.14.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing v10 make sense since it is not supported. But we should be testing all supported Node.js versions: 12, 14, 16, and 17. https://nodejs.org/en/about/releases/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply forgot this there, sorry.

Comment on lines -3 to +6
[![NPM version](http://img.shields.io/npm/v/gulp-stylelint.svg)](https://www.npmjs.org/package/gulp-stylelint)
[![Build Status](https://travis-ci.org/olegskl/gulp-stylelint.svg?branch=master)](https://travis-ci.org/olegskl/gulp-stylelint)
[![Dependency Status](https://david-dm.org/olegskl/gulp-stylelint.svg)](https://david-dm.org/olegskl/gulp-stylelint)
[![Join the chat at https://gitter.im/olegskl/gulp-stylelint](https://badges.gitter.im/olegskl/gulp-stylelint.svg)](https://gitter.im/olegskl/gulp-stylelint?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
[![NPM version](http://img.shields.io/npm/v/@ronilaukkarinen/gulp-stylelint.svg)](https://www.npmjs.org/package/@ronilaukkarinen/gulp-stylelint)
[![Build Status](https://travis-ci.org/olegskl/gulp-stylelint.svg?branch=master)](https://travis-ci.org/ronilaukkarinen/gulp-stylelint)

**This is a fork of [olegskl/gulp-stylelint](https://github.com/olegskl/gulp-stylelint) which seems to have been sleeping for a long time. This fork aims to have always up to date [stylelint](https://github.com/stylelint/stylelint) version.**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense for your forked version, but these changes can't be put into this repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I should have make a separate branch for the PR, I have to close this PR for now.

npm install stylelint gulp-stylelint --save-dev
npm install stylelint @ronilaukkarinen/gulp-stylelint --save-dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I should have make a separate branch for the PR, I have to close this PR for now.

"name": "gulp-stylelint",
"version": "13.0.0",
"name": "@ronilaukkarinen/gulp-stylelint",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto above.

"node": ">=10.12.0"
"node": ">=15.14.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be >=12

@PanzerKunst
Copy link

Thanks for you work to support Stylelint v14.
Are you planning to continue working on a PR enabling that support?

@ronilaukkarinen
Copy link
Author

@PanzerKunst I personally have no time to create a separate PR at the moment so I'm using my previously created fork until I have more time... the repo maintainer @olegskl has been silent for a long time, please see #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants