forked from percona/percona-server
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upstream commit ID : fb-mysql-5.6.35/269d05b0beb761d9f9ba057f12b62b0077a3c4a2 PS-6864 : Merge fb-prod201902 Summary: Enable atomic bulk loading - bulk loading using SST APIs are now atomic. You should not observe any in between state if there is any failures in ingestion (there are some caveats, as usual, that needs to be investigated/documented). This change essentially delays all SST ingestion until finish_bulk_load, and ingest them all in one batch. Care is taken to: 1. Make sure the state management of multiple `Rdb_sst_info` are done transactionally as well to match the ingestion, 2. Works well with closing connections and ALTER TABLE statement race conditions (however under race conditions the ingestion are forcefully interrupted and therefore no longer truly atomic - this needs to be investigated to see if there are other approaches). 3. Files are properly cleaned up in the failure case NOTE: I specifically avoided doing refactoring in order to make code review easier. Finish_bulk_load is becoming too big and that will get addressed later. This changes takes advantage of latest [PR][(facebook/rocksdb#4895) from Yanqin Jin which supports ingesting SST from multiple column families. NOTE: This change updates rocksdb to latest commit in the PR and will update to the proper rocksdb version once the PR is merged and we've decided on a proper RocksDB version to consume. update-submodule: rocksdb fbshipit-source-id: 767c36232b6
- Loading branch information
1 parent
f165508
commit c0bfb74
Showing
13 changed files
with
390 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.