Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 - Next (beta) #238

Merged
merged 22 commits into from Oct 2, 2022
Merged

Vue 3 - Next (beta) #238

merged 22 commits into from Oct 2, 2022

Conversation

oleksiikhr
Copy link
Owner

@oleksiikhr oleksiikhr commented Jan 20, 2022

close #143
close #196
close #246

Bringing the repository to new standards and technologies.

@netlify
Copy link

netlify bot commented Jan 23, 2022

Deploy Preview for vue-stripe-menu ready!

Name Link
🔨 Latest commit bff8c46
🔍 Latest deploy log https://app.netlify.com/sites/vue-stripe-menu/deploys/6339963b2c1d80000823da6a
😎 Deploy Preview https://deploy-preview-238--vue-stripe-menu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

</template>
<template #default="{ item }">
<component :is="item.component" />
</template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do something like this:

<template #default>
    <div>Page 1</div>
    <div>Page 2</div>
    <div>Page 3</div>
</template>

or

<template #default>
    <template>Page 1</template>
    <template>Page 2</template>
    <template>Page 3</template>
</template>
<template #default>
    <template v-for="item in menuItems">{{ item.content }}</template>
</template>

This gives the user more control, although I don't know how you would integrate the nav bar and all that custom attribute logic that way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe with a prop or something that holds a menu item object with all the extra info like title, element, etc.

@alexanderhorner
Copy link
Contributor

Hey, how are you doing? Any way to help with this?

@oleksiikhr oleksiikhr marked this pull request as ready for review October 2, 2022 12:32
@oleksiikhr oleksiikhr changed the title WIP: Next Vue 3 - Next (beta) Oct 2, 2022
@alexanderhorner
Copy link
Contributor

This is awesome!! and works flawlessly. Just can't deploy it yet because of the package.json exports issue.

@alexanderhorner
Copy link
Contributor

Another thing I noticed is that animating the background using the width and height properties stutters in power saving mode (and I assume also in some other cases, on slow devices for example).

It’s the straight forward way, and maybe it can be fixed some other way? If not, you maybe could use transform scale, but then do some math to correct the border-radius… idk, I can’t think of some other solution to that rn. Some more testing can’t hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

border-radius is stretched with the background Not Vue 3 compatible How to use with nuxt ?
2 participants