New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 - Next (beta) #238
Vue 3 - Next (beta) #238
Conversation
✅ Deploy Preview for vue-stripe-menu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
docs/src/components/BaseHeader.vue
Outdated
</template> | ||
<template #default="{ item }"> | ||
<component :is="item.component" /> | ||
</template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do something like this:
<template #default>
<div>Page 1</div>
<div>Page 2</div>
<div>Page 3</div>
</template>
or
<template #default>
<template>Page 1</template>
<template>Page 2</template>
<template>Page 3</template>
</template>
<template #default>
<template v-for="item in menuItems">{{ item.content }}</template>
</template>
This gives the user more control, although I don't know how you would integrate the nav bar and all that custom attribute logic that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe with a prop or something that holds a menu item object with all the extra info like title, element, etc.
Hey, how are you doing? Any way to help with this? |
This is awesome!! and works flawlessly. Just can't deploy it yet because of the package.json exports issue. |
Another thing I noticed is that animating the background using the width and height properties stutters in power saving mode (and I assume also in some other cases, on slow devices for example). It’s the straight forward way, and maybe it can be fixed some other way? If not, you maybe could use transform scale, but then do some math to correct the border-radius… idk, I can’t think of some other solution to that rn. Some more testing can’t hurt. |
close #143
close #196
close #246
Bringing the repository to new standards and technologies.