Fix package exports #251
Merged
Fix package exports #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-stripe-menu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
|
Fixes #250 |
oleksiikhr
reviewed
Oct 3, 2022
| @@ -13,7 +13,9 @@ | |||
| ".": { | |||
| "import": "./dist/vue-stripe-menu.es.js", | |||
| "require": "./dist/vue-stripe-menu.umd.js" | |||
| } | |||
| }, | |||
| "./css": "./dist/vue-stripe-menu.css", | |||
There was a problem hiding this comment.
Thanks for the PR.
I think we should leave current import for backward compatibility.
These imports should work just as they did:
vue-stripe-menu/src/scss/index
vue-stripe-menu/dist/vue-stripe-menu.css
etc
But I don't really know what it should look like.
{
"./dist/*": "./dist/*",
"./src/*": "./src/*"
}
There was a problem hiding this comment.
I added the two 'legacy' exports (additionally to the new ones)
"./css": "./dist/vue-stripe-menu.css",
"./scss": "./src/scss/index.scss",
"./dist/vue-stripe-menu.css": "./dist/vue-stripe-menu.css",
"./src/scss/index": "./src/scss/index.scss"There was a problem hiding this comment.
"./dist/*": "./dist/*",
"./src/*": "./src/*"Works too btw, but I guess it's not recommended.
oleksiikhr
approved these changes
Oct 3, 2022
|
Forgot to change version number to 3.0.0-beta.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new exports:
So for <script>:
or <style>: