Support -Zbuild-std

[daxpedda]

As discussed in #197 (comment).

Fixes #197.

[oli-obk]

I think it would be simpler to have a build_std bool field on DependencyBuilder and manually inject the -Z flags instead of expecting the user to supply them and have us detect them

[daxpedda]

This couldn't be a bool because sometimes its relevant to pass arguments like -Zbuild-std=std,panic_abort.
But I could instead make it an Option<String>?

I think another motivation to not add a configuration is that when rust-lang/wg-cargo-std-aware#20 is addressed, we wouldn't need a configuration either.

Let me know how you want me to proceed.

[oli-obk]

But I could instead make it an Option<String>?

yea that seems good

I think another motivation to not add a configuration is that when rust-lang/wg-cargo-std-aware#20 is addressed, we wouldn't need a configuration either.

I'm doing regular major bumps anyway, seems fine to do another once that lands (or just mark it as deprecated then)

[daxpedda]

Done.

After trying it out though I have to say its a bit weird, because now if the user supplies the -Zbuild-std argument without enabling the DependencyBuilder::build_std option, it won't work.

Old Version: daxpedda@72346fd (leaving this here just in case if you change your mind)

[oli-obk]

is there any reasonably small test that we can add here so I don't accidentally make it stop working in the future?

[daxpedda]

is there any reasonably small test that we can add here so I don't accidentally make it stop working in the future?

Would love to, but I would need some guidance to do that, would you put the test in integration or unit tests?
I see that you didn't manage adding a test in #196, which I would have drawn inspiration from.

[oli-obk]

I see that you didn't manage adding a test in #196, which I would have drawn inspiration from.

that one was specifically for cross compilation, which is a bit annoying. Here we can just build-std for the host itself. You can probably just add a copy of the config in

ui_test/tests/integrations/basic/tests/ui_tests.rs

Line 39 in 9f5fec5

vec![config],

with build-std enabled

[daxpedda]

I see that you didn't manage adding a test in #196, which I would have drawn inspiration from.

that one was specifically for cross compilation, which is a bit annoying. Here we can just build-std for the host itself. You can probably just add a copy of the config in

ui_test/tests/integrations/basic/tests/ui_tests.rs

Line 39 in 9f5fec5

vec![config],

with build-std enabled

I had to use basic-bin instead, because -Zbuild-std and proc-macros are a bit weird.
The remaining issues are:

• We need to add a nightly configuration to the CI and (done) run this test only when running nightly.
• Other tests should not run in nightly because their output will be different.

I think it might be best to add a separate integration test entirely?

[oli-obk]

I think it might be best to add a separate integration test entirely?

oof yea 😆 that makes sense

[daxpedda]

I think it might be best to add a separate integration test entirely?

oof yea 😆 that makes sense

So I adjusted the integration test to take an env variable to set the folder and then just copied basic-bin with the appropriate build_std addition, which is a bit crude but it works.

I think I could instead make a simple test using ui_test without the whole machinery in place to check the Cargo output?
Let me know what you think.

[oli-obk]

I think I could instead make a simple test using ui_test without the whole machinery in place to check the Cargo output?
Let me know what you think.

right, we only care that it works, not what the output is

[daxpedda]

I think I could instead make a simple test using ui_test without the whole machinery in place to check the Cargo output?
Let me know what you think.

right, we only care that it works, not what the output is

Done, let me know if you want any other adjustments.

(sorry for the delay)

[oli-obk]

Thanks! This is great!