-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy metadata/hitsound to a difficulty while opening it in the editor causes an absurdly large file size #55
Comments
From what I see in the screenshot, the length doesn't seem to be the only issue. All the objects have an absurd coordinate and time value and some sliders have 0 length. Hitsound Copier and Metadata Manager also don't touch hitobjects all that much, so I think there's something wrong with the beatmap IO. |
You say this only happens when you have the editor open with the beatmap you are copying to? It works completely fine when you don't have the editor open? |
Yes, But this seems quite random (for some maps, both the hitsound copier and metadata manager work fine even with a certain diff in the set opening in the editor) |
I can't recreate the bug on my laptop, so I'm gonna assume it's a problem with editor reader. Next update will have an option to disable editor reader if it doesn't work on your pc for some reason. I might also add some sanity checks to see if what editor reader does makes sense. |
Which diff is open in the editor, the one you are copying from or copying to? |
The one I'm copying to. |
It sounds like an issue with the memory reading (which I am responsible for), where the game is taking a while to dispose of an older editor instance. It should be a rare random occurrence when opening and closing the editor more than once, but if you are able to get this behavior consistently, please explain in detail what steps you are doing. Otherwise, I will look into a fast way to detect multiple editor instances, it is currently not detected because it would take a few seconds every time the map is read. |
I dont know if it will be possible to fix this issue if it's this inconsistent and I can't reproduce it. I can't see all the internal values that could give a hint to where the problem could be. The only option I see would be to log absolutely everything to some debug file so you can find the relevant information afterwards. |
I think what you said confirms my previous comment, I will have to find a way to distinguish partially disposed editors from the active one. |
Yo i think i fixed this with the latest commit. There might still be a tiny chance it does weird stuff, but at least it shouldn't create huge files anymore. |
For the information: I'm using Windows 10 Professional ver. 1809, and the Mapping Tools is ver. 1.3.0.0.
(Map in case you need it)
When I tried to copy hitsounds / metadata by using hitsound copier / metadata manager with a diff opening in the editor, they have randomly added many zeros in the [Hitobjects] section:
![image](https://user-images.githubusercontent.com/52080494/66715057-6f329d00-edf1-11e9-893a-cf9e8caa0c2a.png)
![image](https://user-images.githubusercontent.com/52080494/66715083-9d17e180-edf1-11e9-8a0a-d7c56224394a.png)
And it results in an absurdly large file size: (sorry it is in chinese but I believe you can get me)
The text was updated successfully, but these errors were encountered: