perf: faster datatree render performance #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents dom being destroyed and created repeatedly, It is most beneficial withe a deeply nested tree.
looping the array and push to the existing array is much faster than using concat and assign. I believe this is because concat creates a new array each time it is called.
lukecotter
changed the title
lukecotter
changed the title
|
Hey @lukecotter Thanks for the PR, great work there! I will merge this in to the 6.0 branch now and include it in todays release. Cheers Oli :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2X faster datatree render performance
I tested these changes with a tree with 251890 nodes that can be expanded. I takes ~2.5 seconds to apply one of my filters with these changes and all nodes full expanded.
Before the changes it was ~6.5 seconds with the same data.
Before
The filter seems to take much longer when the chrome profiler is running, the timing I stated above are more accurate when the profiler is not running
After
resolves #4336