Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly calculated height on collapes rows #4425

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

antman3351
Copy link
Contributor

Hey Oli,

as mentioned in the issue #3654 ( So i'm going to copy and paste a bit 馃槣 )

I noticed in the VirtualDomVertical module in _removeTopRow the row height is always the same even though the rows are not the same height.

I think the issue is the column height isn't recalculated after the rows are collapsed, so I've added a call to calcHeight() after the rows are collapsed.

Cheers,
Antonio

@olifolkerd
Copy link
Owner

Hey @antman3351

Thanks for the PR, it definitly should recalc row height after the collapse event, so thanks for that, but this wont fix the issue outlined in #3654 which is a wider issue to do with how the vdom handles adjustment of variable height rows in its calculations.

I will merge this in as it should certainly be included

Cheers

Oli :)

@olifolkerd olifolkerd changed the base branch from master to 6.0 March 17, 2024 09:54
@olifolkerd olifolkerd merged commit a82a372 into olifolkerd:6.0 Mar 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants