fix navigation with rowheader #4457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigating to left with keyboard can make it select the rowHeader. To fix this, we check if rowHeader exists from SelectRange. Range is not responsible for checking rowHeader for the most part anymore.
|
This PR causes other bugs. Closing in favor of #4459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigating to left with keyboard can make it select the
rowHeader.Here's the demo to replicate: https://jsfiddle.net/dbjzcw0e/
rowHeaderrowHeaderwith mouseTo fix this, we can check if
rowHeaderexists in SelectRange. Range is not responsible for checkingrowHeaderfor the most part anymore. Also, that seems to simplify the code a lot.