Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update.php relationships part setPropertyValue gets object instead of string #22

Closed
bjolar opened this issue Dec 12, 2017 · 2 comments
Closed

Update.php relationships part setPropertyValue gets object instead of string #22

bjolar opened this issue Dec 12, 2017 · 2 comments
Labels
bug

Comments

@bjolar
Copy link
Contributor

bjolar commented Dec 12, 2017

Description

Update.php has a typo where
ClassHelper::setPropertyValue($entity, $relatedProperty, $reference);
Should have a "$relatedType" as the second argument instead of "$relatedProperty". $relatedType should also be "deKebabifyed" otherwise Jad can't find the Entity.
@oligus oligus added the bug label Dec 13, 2017
@bjolar
Copy link
Contributor Author

bjolar commented Dec 14, 2017

Same issue in Create.php

@oligus oligus closed this as completed Dec 15, 2017
@bjolar
Copy link
Contributor Author

bjolar commented Jan 8, 2018

Re-open, this is not fixed

@oligus oligus reopened this Jan 8, 2018
oligus added a commit that referenced this issue Jan 9, 2018
@oligus
Merge pull request #32 from bjolar/master
a84aa6b 
Issue #22 fix
@oligus oligus closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oligus @bjolar