Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] telescope extension not support width = { val, min, max } #34

Closed
adoyle-h opened this issue Oct 20, 2022 · 1 comment · Fixed by #35
Closed

[Bug] telescope extension not support width = { val, min, max } #34

adoyle-h opened this issue Oct 20, 2022 · 1 comment · Fixed by #35
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@adoyle-h
Copy link
Contributor

My default telescope config:

layout_config = {
  vertical = {
    height = { 0.8, min = 30, max = 80 },
    width = { 0.8, min = 80, max = 130 }
  }
}

persisted telescope extension will throw an error.

The extension should use the resolver.resolve_width() .
@olimorris
Copy link
Owner

Tbh my knowledge with all things Telescope is minimal these days. Happy to accept a PR.

@olimorris olimorris added help wanted Extra attention is needed bug Something isn't working labels Oct 20, 2022
adoyle-h added a commit to adoyle-h/persisted.nvim that referenced this issue Oct 21, 2022
@adoyle-h
fix(telescope): support width = { val, min, max } and show branch
e4eb2d3 
- Use telescope builtin resolver to calculate width.
- The branch is missing. Fixed.
- If session file stores without git branch, `session.branch` should be nil. And do not show branch in list.
- `make test` will fail because plenary.nvim is old.

close olimorris#34
@adoyle-h adoyle-h mentioned this issue Oct 21, 2022
Merged
adoyle-h added a commit to adoyle-h/persisted.nvim that referenced this issue Oct 24, 2022
@adoyle-h
fix(telescope): support width = { val, min, max } and show branch
89a58c6 
- Use telescope builtin resolver to calculate width.
- The branch is missing. Fixed.
- If session file stores without git branch, `session.branch` should be nil. And do not show branch in list.
- `make test` will fail because plenary.nvim is old.

close olimorris#34
olimorris pushed a commit that referenced this issue Oct 25, 2022
@adoyle-h
fix: #34 support width = { val, min, max } and show branch
80c898a 
- Use telescope builtin resolver to calculate width.
- The branch is missing. Fixed.
- If session file stores without git branch, `session.branch` should be nil. And do not show branch in list.
- `make test` will fail because plenary.nvim is old.

close #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(telescope): support width = { val, min, max } and show branch adoyle-h/persisted.nvim
2 participants
@adoyle-h @olimorris